Changing old react component to use react hooks#47
Open
deveix wants to merge 1 commit intoNadiKuts:masterfrom
Open
Changing old react component to use react hooks#47deveix wants to merge 1 commit intoNadiKuts:masterfrom
deveix wants to merge 1 commit intoNadiKuts:masterfrom
Conversation
deveix
force-pushed
the
react-0.95-update
branch
4 times, most recently
from
f5b5d3c to
3c6aac4
Compare
deveix
force-pushed
the
react-0.95-update
branch
from
3c6aac4 to
ac5cf54
Compare
naderalfakesh
suggested changes
May 22, 2021
naderalfakesh
left a comment
naderalfakesh
left a comment
There was a problem hiding this comment.
Your file formatter is using tabs but the original repo files are using 2 spaces.
Maybe changing to that for this PR will reduce the amount of changes to its gist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used react v0.63.4 and i found out that this repo needs refactoring to use hooks and lose all outdated component lifecycles.
i don't know if you want to keep it for the users using old react native versions or not you make the decision i just wrote the code that worked for my app.
Thanks in advance.